Regression in loc.setitem raising ValueError with unordered MultiIndex columns and scalar indexer #39071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x columns and scalar indexer
phofl
added
Indexing
jreback
requested changes
Jan 9, 2021
| @@ -1685,6 +1685,15 @@ def test_getitem_interval_index_partial_indexing(self): | |||
| res = df.loc[:, 0.5] | |||
| tm.assert_series_equal(res, expected) | |||
|
|
|||
| @pytest.mark.parametrize("indexer", ["A", ["A"]]) | |||
There was a problem hiding this comment.
can you add the other 3 cases from OP that 'work fine' (2 x slice and a sorted case). ok to have another test if helpful.
There was a problem hiding this comment.
Done, worked through parametrization
I think you're right, yes |
|
Changed it then |
jreback
approved these changes
Jan 10, 2021
|
lgtm. will merge / backport on green. |
|
Merged master again to fix benchmarks, will ping on green |
|
@jreback green |
|
this @phofl |
|
@meeseeksdev backport 1.2.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Jan 10, 2021
…Error with unordered MultiIndex columns and scalar indexer
simonjayhawkins
pushed a commit
that referenced
this pull request
Jan 11, 2021
… unordered MultiIndex columns and scalar indexer (#39084) Co-authored-by: patrick <[email protected]>
|
|
Interesting, but should not matter? |
|
I don't think this makes a difference, we are always looping over the result as far as I can see. |
luckyvs1
pushed a commit
to luckyvs1/pandas
that referenced
this pull request
Jan 20, 2021
…x columns and scalar indexer (pandas-dev#39071) * Regression in loc.setitem raising ValueError with unordered MultiIndex columns and scalar indexer * Add tests * Improve performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jbrockmendel Would it be faster to use arange too in the line above of my fix instead of Index?